From 3ffd6dde005e7d45135d9ed4eae904514cdcb2a1 Mon Sep 17 00:00:00 2001 From: sturdy4days <58111365+sturdy4days@users.noreply.github.com> Date: Wed, 17 Jun 2026 15:19:29 -0400 Subject: [PATCH] refactor: remove dead resolveGroupIpcPath resolveGroupIpcPath has no production callers (only its own test); IPC was removed in the v2 architecture (host<->container communicate solely via the two session DBs). Drop the function, the now-unused DATA_DIR import, and its tests. --- src/group-folder.test.ts | 8 +------- src/group-folder.ts | 10 +--------- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/src/group-folder.test.ts b/src/group-folder.test.ts index cc772109a..acc796a2e 100644 --- a/src/group-folder.test.ts +++ b/src/group-folder.test.ts @@ -2,7 +2,7 @@ import path from 'path'; import { describe, expect, it } from 'vitest'; -import { isValidGroupFolder, resolveGroupFolderPath, resolveGroupIpcPath } from './group-folder.js'; +import { isValidGroupFolder, resolveGroupFolderPath } from './group-folder.js'; describe('group folder validation', () => { it('accepts normal group folder names', () => { @@ -23,13 +23,7 @@ describe('group folder validation', () => { expect(resolved.endsWith(`${path.sep}groups${path.sep}family-chat`)).toBe(true); }); - it('resolves safe paths under data ipc directory', () => { - const resolved = resolveGroupIpcPath('family-chat'); - expect(resolved.endsWith(`${path.sep}data${path.sep}ipc${path.sep}family-chat`)).toBe(true); - }); - it('throws for unsafe folder names', () => { expect(() => resolveGroupFolderPath('../../etc')).toThrow(); - expect(() => resolveGroupIpcPath('/tmp')).toThrow(); }); }); diff --git a/src/group-folder.ts b/src/group-folder.ts index 57459540f..13a2e386b 100644 --- a/src/group-folder.ts +++ b/src/group-folder.ts @@ -1,6 +1,6 @@ import path from 'path'; -import { DATA_DIR, GROUPS_DIR } from './config.js'; +import { GROUPS_DIR } from './config.js'; const GROUP_FOLDER_PATTERN = /^[A-Za-z0-9][A-Za-z0-9_-]{0,63}$/; const RESERVED_FOLDERS = new Set(['global']); @@ -34,11 +34,3 @@ export function resolveGroupFolderPath(folder: string): string { ensureWithinBase(GROUPS_DIR, groupPath); return groupPath; } - -export function resolveGroupIpcPath(folder: string): string { - assertValidGroupFolder(folder); - const ipcBaseDir = path.resolve(DATA_DIR, 'ipc'); - const ipcPath = path.resolve(ipcBaseDir, folder); - ensureWithinBase(ipcBaseDir, ipcPath); - return ipcPath; -}