From 6c2d26836f7b4b6bf526b0fea6fb16debcecf572 Mon Sep 17 00:00:00 2001 From: leetwito Date: Sat, 4 Jul 2026 15:38:38 +0300 Subject: [PATCH] fix(add-clidash): mkdir -p tools in install step; require Node >=22.5 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Address review feedback on PR #2795: - SKILL.md Step 1 now creates tools/ before cp -R (cp does not create intermediate parents; tools/ is not a standard NanoClaw dir, so the copy failed on a fresh checkout). - package.json engines bumped to >=22.5 — server.js statically imports activity.js -> node:sqlite (DatabaseSync), which lands in Node 22.5, so the server crashed at module load on Node 20/21 LTS. - Doc references (SKILL.md, README.md) updated to Node >=22.5 for consistency. Verified 87/87 tests pass on Node 22.14. --- .claude/skills/add-clidash/SKILL.md | 6 +++++- .claude/skills/add-clidash/add/tools/clidash/README.md | 3 ++- .claude/skills/add-clidash/add/tools/clidash/package.json | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.claude/skills/add-clidash/SKILL.md b/.claude/skills/add-clidash/SKILL.md index c609c3367..93214fa9e 100644 --- a/.claude/skills/add-clidash/SKILL.md +++ b/.claude/skills/add-clidash/SKILL.md @@ -41,7 +41,11 @@ build step, no push pipeline, and no edits to NanoClaw source — it just reads clidash is fully self-contained — copy the whole directory in: +`tools/` is not a standard NanoClaw directory and `cp -R` won't create it, so +make it first: + ```bash +mkdir -p tools cp -R .claude/skills/add-clidash/add/tools/clidash tools/clidash ``` @@ -76,7 +80,7 @@ Tests use a stub CLI — no real `ncl` or `docker` needed: npm test ``` -All tests should pass (Node ≥ 20, `node:test`, zero dependencies). +All tests should pass (Node ≥ 22.5, `node:test`, zero dependencies). ### 4. Run and verify diff --git a/.claude/skills/add-clidash/add/tools/clidash/README.md b/.claude/skills/add-clidash/add/tools/clidash/README.md index fa4c2f6c4..7fd89eff2 100644 --- a/.claude/skills/add-clidash/add/tools/clidash/README.md +++ b/.claude/skills/add-clidash/add/tools/clidash/README.md @@ -9,7 +9,8 @@ It ships pre-wired for NanoClaw's `ncl` CLI (agent groups, sessions, messaging groups, wirings, users, roles, …) plus `docker`, but the same config shape works for any list-as-JSON CLI. -- **Zero dependencies** — Node built-ins only (Node ≥ 20), no build step, +- **Zero dependencies** — Node built-ins only (Node ≥ 22.5, for `node:sqlite`), + no build step, vanilla-JS frontend. - **Read-only by construction** — the server can only `execFile` the configured argv templates; `{resource}` is the sole substitution and is validated diff --git a/.claude/skills/add-clidash/add/tools/clidash/package.json b/.claude/skills/add-clidash/add/tools/clidash/package.json index 7927bf18a..347d277f3 100644 --- a/.claude/skills/add-clidash/add/tools/clidash/package.json +++ b/.claude/skills/add-clidash/add/tools/clidash/package.json @@ -9,6 +9,6 @@ "test": "node --test 'test/*.test.js'" }, "engines": { - "node": ">=20" + "node": ">=22.5" } }