mirror of
https://github.com/qwibitai/nanoclaw.git
synced 2026-06-12 18:11:51 +08:00
fc375ca72b
setup/register.ts had two bugs that prevented new channels from being
registered via `/manage-channels`:
1. createMessagingGroupAgent was called with the legacy field names
`trigger_rules` and `response_scope`. The SQL INSERT expects
`engage_mode` / `engage_pattern` / `sender_scope` / `ignored_message_policy`
(migration 010). Every register call failed with
`RangeError: Missing named parameter "engage_mode"` after the agent
and messaging group were partially created — leaving an orphaned pair.
Now mirrors scripts/init-first-agent.ts:wireIfMissing:
- Groups (is_group=1) default to engage_mode='mention' (bot only
responds when addressed).
- DMs (is_group=0) default to engage_mode='pattern' with '.' (respond
to every message).
- An explicit --trigger overrides the pattern regex.
2. The "normalize platform_id" block unconditionally prefixed
"<channel>:" even for native IDs like WhatsApp JIDs
("120363408974444974@g.us"), iMessage emails ("user@example.com"),
or Signal phones ("+15551234567") / Signal groups ("group:abc"). But
the router (src/router.ts:158) looks up messaging_groups by the raw
event.platformId from the adapter, which for these native adapters
never has a prefix. So the prefixed row was never matched — the
message was silently dropped with no "Message routed" log.
Extracted scripts/init-first-agent.ts:namespacedPlatformId into
src/platform-id.ts so both setup paths use the same heuristic (skip
the prefix for IDs containing '@', starting with '+', or starting
with 'group:'). Prevents future drift between the two paths.
Tested by: re-running `setup/index.ts --step register` for a WhatsApp
group JID, confirming the row is created with correct engage fields
and matching platform_id, then sending a test message and observing
"Message routed" with the right agent group.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
261 lines
8.9 KiB
TypeScript
261 lines
8.9 KiB
TypeScript
/**
|
|
* Step: register — Create v2 entities (agent group, messaging group, wiring).
|
|
*
|
|
* Writes to the v2 central DB (data/v2.db) — NOT the v1 store/messages.db.
|
|
* Creates: agent_group, messaging_group, messaging_group_agents.
|
|
*/
|
|
import fs from 'fs';
|
|
import path from 'path';
|
|
|
|
import { DATA_DIR } from '../src/config.js';
|
|
import { initDb } from '../src/db/connection.js';
|
|
import { runMigrations } from '../src/db/migrations/index.js';
|
|
import { createAgentGroup, getAgentGroupByFolder } from '../src/db/agent-groups.js';
|
|
import {
|
|
createMessagingGroup,
|
|
createMessagingGroupAgent,
|
|
getMessagingGroupByPlatform,
|
|
getMessagingGroupAgentByPair,
|
|
} from '../src/db/messaging-groups.js';
|
|
import { isValidGroupFolder } from '../src/group-folder.js';
|
|
import { initGroupFilesystem } from '../src/group-init.js';
|
|
import { log } from '../src/log.js';
|
|
import { namespacedPlatformId } from '../src/platform-id.js';
|
|
import { resolveSession, writeSessionMessage } from '../src/session-manager.js';
|
|
import { emitStatus } from './status.js';
|
|
|
|
interface RegisterArgs {
|
|
/** Platform-specific channel/group ID (Discord channel ID, Slack channel, etc.) */
|
|
platformId: string;
|
|
/** Human-readable name for the messaging group */
|
|
name: string;
|
|
/** Trigger pattern (regex or keyword) */
|
|
trigger: string;
|
|
/** Agent group folder name */
|
|
folder: string;
|
|
/** Channel type (discord, slack, telegram, etc.) */
|
|
channel: string;
|
|
/** Whether messages require the trigger pattern to activate */
|
|
requiresTrigger: boolean;
|
|
/** Display name for the assistant */
|
|
assistantName: string;
|
|
/** Session mode: 'shared' (one session per channel) or 'per-thread' */
|
|
sessionMode: string;
|
|
}
|
|
|
|
function parseArgs(args: string[]): RegisterArgs {
|
|
const result: RegisterArgs = {
|
|
platformId: '',
|
|
name: '',
|
|
trigger: '',
|
|
folder: '',
|
|
channel: 'discord',
|
|
requiresTrigger: false,
|
|
assistantName: 'Andy',
|
|
sessionMode: 'shared',
|
|
};
|
|
|
|
for (let i = 0; i < args.length; i++) {
|
|
switch (args[i]) {
|
|
case '--platform-id':
|
|
result.platformId = args[++i] || '';
|
|
break;
|
|
case '--name':
|
|
result.name = args[++i] || '';
|
|
break;
|
|
case '--trigger':
|
|
result.trigger = args[++i] || '';
|
|
break;
|
|
case '--folder':
|
|
result.folder = args[++i] || '';
|
|
break;
|
|
case '--channel':
|
|
result.channel = (args[++i] || '').toLowerCase();
|
|
break;
|
|
case '--no-trigger-required':
|
|
result.requiresTrigger = false;
|
|
break;
|
|
case '--assistant-name':
|
|
result.assistantName = args[++i] || 'Andy';
|
|
break;
|
|
case '--session-mode':
|
|
result.sessionMode = args[++i] || 'shared';
|
|
break;
|
|
}
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
function generateId(prefix: string): string {
|
|
return `${prefix}-${Date.now()}-${Math.random().toString(36).slice(2, 8)}`;
|
|
}
|
|
|
|
export async function run(args: string[]): Promise<void> {
|
|
const projectRoot = process.cwd();
|
|
const parsed = parseArgs(args);
|
|
|
|
if (!parsed.platformId || !parsed.name || !parsed.folder) {
|
|
emitStatus('REGISTER_CHANNEL', {
|
|
STATUS: 'failed',
|
|
ERROR: 'missing_required_args',
|
|
LOG: 'logs/setup.log',
|
|
});
|
|
process.exit(4);
|
|
}
|
|
|
|
if (!isValidGroupFolder(parsed.folder)) {
|
|
emitStatus('REGISTER_CHANNEL', {
|
|
STATUS: 'failed',
|
|
ERROR: 'invalid_folder',
|
|
LOG: 'logs/setup.log',
|
|
});
|
|
process.exit(4);
|
|
}
|
|
|
|
// Normalize platform_id to the same shape the adapter will emit at runtime,
|
|
// so the router's (channel_type, platform_id) lookup matches what we store.
|
|
// Chat SDK adapters prefix, native adapters (WhatsApp/iMessage/Signal) don't.
|
|
parsed.platformId = namespacedPlatformId(parsed.channel, parsed.platformId);
|
|
|
|
log.info('Registering channel', parsed);
|
|
|
|
// Init v2 central DB
|
|
fs.mkdirSync(path.join(projectRoot, 'data'), { recursive: true });
|
|
const dbPath = path.join(DATA_DIR, 'v2.db');
|
|
const db = initDb(dbPath);
|
|
runMigrations(db);
|
|
|
|
// 1. Create or find agent group
|
|
let agentGroup = getAgentGroupByFolder(parsed.folder);
|
|
if (!agentGroup) {
|
|
const agId = generateId('ag');
|
|
createAgentGroup({
|
|
id: agId,
|
|
name: parsed.assistantName,
|
|
folder: parsed.folder,
|
|
agent_provider: null,
|
|
created_at: new Date().toISOString(),
|
|
});
|
|
agentGroup = getAgentGroupByFolder(parsed.folder)!;
|
|
log.info('Created agent group', { id: agId, folder: parsed.folder });
|
|
}
|
|
initGroupFilesystem(agentGroup);
|
|
|
|
// 2. Create or find messaging group
|
|
let messagingGroup = getMessagingGroupByPlatform(parsed.channel, parsed.platformId);
|
|
if (!messagingGroup) {
|
|
const mgId = generateId('mg');
|
|
createMessagingGroup({
|
|
id: mgId,
|
|
channel_type: parsed.channel,
|
|
platform_id: parsed.platformId,
|
|
name: parsed.name,
|
|
is_group: 1,
|
|
unknown_sender_policy: 'strict',
|
|
created_at: new Date().toISOString(),
|
|
});
|
|
messagingGroup = getMessagingGroupByPlatform(parsed.channel, parsed.platformId)!;
|
|
log.info('Created messaging group', { id: mgId, channel: parsed.channel, platformId: parsed.platformId });
|
|
}
|
|
|
|
// 3. Wire agent to messaging group — createMessagingGroupAgent auto-creates
|
|
// the companion agent_destinations row so delivery's ACL admits this target.
|
|
let newlyWired = false;
|
|
const existing = getMessagingGroupAgentByPair(messagingGroup.id, agentGroup.id);
|
|
if (!existing) {
|
|
newlyWired = true;
|
|
const mgaId = generateId('mga');
|
|
// Mirrors scripts/init-first-agent.ts:wireIfMissing so both setup paths
|
|
// create rows with the same shape. Groups default to 'mention' (bot only
|
|
// responds when addressed); DMs default to 'pattern'/'.' (respond to
|
|
// every message). An explicit --trigger overrides the pattern regex.
|
|
const isGroup = messagingGroup.is_group === 1;
|
|
const engageMode: 'pattern' | 'mention' = isGroup && !parsed.trigger ? 'mention' : 'pattern';
|
|
const engagePattern: string | null = engageMode === 'pattern' ? parsed.trigger || '.' : null;
|
|
createMessagingGroupAgent({
|
|
id: mgaId,
|
|
messaging_group_id: messagingGroup.id,
|
|
agent_group_id: agentGroup.id,
|
|
engage_mode: engageMode,
|
|
engage_pattern: engagePattern,
|
|
sender_scope: 'all',
|
|
ignored_message_policy: 'drop',
|
|
session_mode: parsed.sessionMode as 'shared' | 'per-thread' | 'agent-shared',
|
|
priority: 0,
|
|
created_at: new Date().toISOString(),
|
|
});
|
|
log.info('Wired agent to messaging group', {
|
|
mgaId,
|
|
agentGroup: agentGroup.id,
|
|
messagingGroup: messagingGroup.id,
|
|
});
|
|
}
|
|
|
|
// 4. Send onboarding message — only on first wiring, not re-registration
|
|
if (newlyWired) {
|
|
const { session } = resolveSession(agentGroup.id, messagingGroup.id, null, parsed.sessionMode as 'shared' | 'per-thread' | 'agent-shared');
|
|
writeSessionMessage(agentGroup.id, session.id, {
|
|
id: generateId('onboard'),
|
|
kind: 'task',
|
|
timestamp: new Date().toISOString(),
|
|
platformId: parsed.platformId,
|
|
channelType: parsed.channel,
|
|
content: JSON.stringify({
|
|
prompt: `A new ${parsed.channel} channel has been connected. Run /welcome to introduce yourself to the user.`,
|
|
}),
|
|
});
|
|
log.info('Onboarding message written', { sessionId: session.id, channel: parsed.channel });
|
|
}
|
|
|
|
// 5. Update assistant name in CLAUDE.md files if different from default
|
|
let nameUpdated = false;
|
|
if (parsed.assistantName !== 'Andy') {
|
|
log.info('Updating assistant name', { from: 'Andy', to: parsed.assistantName });
|
|
|
|
const groupsDir = path.join(projectRoot, 'groups');
|
|
const mdFiles = fs
|
|
.readdirSync(groupsDir)
|
|
.map((d) => path.join(groupsDir, d, 'CLAUDE.md'))
|
|
.filter((f) => fs.existsSync(f));
|
|
|
|
for (const mdFile of mdFiles) {
|
|
let content = fs.readFileSync(mdFile, 'utf-8');
|
|
content = content.replace(/^# Andy$/m, `# ${parsed.assistantName}`);
|
|
content = content.replace(/You are Andy/g, `You are ${parsed.assistantName}`);
|
|
fs.writeFileSync(mdFile, content);
|
|
log.info('Updated CLAUDE.md', { file: mdFile });
|
|
}
|
|
|
|
// Update .env
|
|
const envFile = path.join(projectRoot, '.env');
|
|
if (fs.existsSync(envFile)) {
|
|
let envContent = fs.readFileSync(envFile, 'utf-8');
|
|
if (envContent.includes('ASSISTANT_NAME=')) {
|
|
envContent = envContent.replace(/^ASSISTANT_NAME=.*$/m, `ASSISTANT_NAME="${parsed.assistantName}"`);
|
|
} else {
|
|
envContent += `\nASSISTANT_NAME="${parsed.assistantName}"`;
|
|
}
|
|
fs.writeFileSync(envFile, envContent);
|
|
} else {
|
|
fs.writeFileSync(envFile, `ASSISTANT_NAME="${parsed.assistantName}"\n`);
|
|
}
|
|
log.info('Set ASSISTANT_NAME in .env');
|
|
nameUpdated = true;
|
|
}
|
|
|
|
emitStatus('REGISTER_CHANNEL', {
|
|
PLATFORM_ID: parsed.platformId,
|
|
NAME: parsed.name,
|
|
FOLDER: parsed.folder,
|
|
CHANNEL: parsed.channel,
|
|
TRIGGER: parsed.trigger,
|
|
REQUIRES_TRIGGER: parsed.requiresTrigger,
|
|
ASSISTANT_NAME: parsed.assistantName,
|
|
SESSION_MODE: parsed.sessionMode,
|
|
NAME_UPDATED: nameUpdated,
|
|
STATUS: 'success',
|
|
LOG: 'logs/setup.log',
|
|
});
|
|
}
|