mirror of
https://github.com/qwibitai/nanoclaw.git
synced 2026-06-12 18:11:51 +08:00
ca52d2c6c1
The welcome skill told the agent to send the greeting via `send_message`,
but the destinations system prompt also requires the final response to
be wrapped in `<message to="…">` blocks (since 1d4d920). The agent
followed both, sending the greeting once via the MCP tool and once via
the wrapped final output.
- welcome/SKILL.md: drop the mechanism — "send a short, warm greeting"
lets the system prompt steer how it's delivered.
- destinations.ts: reframe `<message>` blocks and `send_message` as the
same delivery surface, with the explicit note that each call/block
lands as its own message — so they compose into a sequence rather than
reading as additive duplicates of the same content.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
131 lines
5.0 KiB
TypeScript
131 lines
5.0 KiB
TypeScript
/**
|
|
* Destination map — lives in inbound.db's `destinations` table.
|
|
*
|
|
* The host writes this table before every container wake AND on demand
|
|
* (e.g. when a new child agent is created mid-session). The container
|
|
* queries the table live on every lookup, so admin changes take effect
|
|
* immediately — no restart required.
|
|
*
|
|
* This table is BOTH the routing map and the container-visible ACL.
|
|
* The host re-validates on the delivery side against the central DB,
|
|
* so even if this table is stale the host's enforcement is authoritative.
|
|
*/
|
|
import { getInboundDb } from './db/connection.js';
|
|
|
|
export interface DestinationEntry {
|
|
name: string;
|
|
displayName: string;
|
|
type: 'channel' | 'agent';
|
|
channelType?: string;
|
|
platformId?: string;
|
|
agentGroupId?: string;
|
|
}
|
|
|
|
interface DestRow {
|
|
name: string;
|
|
display_name: string | null;
|
|
type: 'channel' | 'agent';
|
|
channel_type: string | null;
|
|
platform_id: string | null;
|
|
agent_group_id: string | null;
|
|
}
|
|
|
|
function rowToEntry(row: DestRow): DestinationEntry {
|
|
return {
|
|
name: row.name,
|
|
displayName: row.display_name ?? row.name,
|
|
type: row.type,
|
|
channelType: row.channel_type ?? undefined,
|
|
platformId: row.platform_id ?? undefined,
|
|
agentGroupId: row.agent_group_id ?? undefined,
|
|
};
|
|
}
|
|
|
|
export function getAllDestinations(): DestinationEntry[] {
|
|
const rows = getInboundDb().prepare('SELECT * FROM destinations ORDER BY name').all() as DestRow[];
|
|
return rows.map(rowToEntry);
|
|
}
|
|
|
|
export function findByName(name: string): DestinationEntry | undefined {
|
|
const row = getInboundDb().prepare('SELECT * FROM destinations WHERE name = ?').get(name) as DestRow | undefined;
|
|
return row ? rowToEntry(row) : undefined;
|
|
}
|
|
|
|
/**
|
|
* Reverse lookup: given routing fields from an inbound message, find
|
|
* which destination they correspond to (what does this agent call the sender?).
|
|
*/
|
|
export function findByRouting(
|
|
channelType: string | null | undefined,
|
|
platformId: string | null | undefined,
|
|
): DestinationEntry | undefined {
|
|
if (!channelType || !platformId) return undefined;
|
|
const db = getInboundDb();
|
|
const row =
|
|
channelType === 'agent'
|
|
? (db
|
|
.prepare("SELECT * FROM destinations WHERE type = 'agent' AND agent_group_id = ?")
|
|
.get(platformId) as DestRow | undefined)
|
|
: (db
|
|
.prepare("SELECT * FROM destinations WHERE type = 'channel' AND channel_type = ? AND platform_id = ?")
|
|
.get(channelType, platformId) as DestRow | undefined);
|
|
return row ? rowToEntry(row) : undefined;
|
|
}
|
|
|
|
/**
|
|
* Generate the system-prompt addendum: agent identity + destination map.
|
|
*
|
|
* Identity is injected here (not in the shared CLAUDE.md) because it's
|
|
* per-agent-group and changes when the operator renames an agent, while
|
|
* the shared base is identical across all agents.
|
|
*/
|
|
export function buildSystemPromptAddendum(assistantName?: string): string {
|
|
const sections: string[] = [];
|
|
|
|
if (assistantName) {
|
|
sections.push(['# You are ' + assistantName, '', `Your name is **${assistantName}**. Use it when the channel asks who you are, when introducing yourself, and when signing any message that explicitly calls for a signature.`].join('\n'));
|
|
}
|
|
|
|
sections.push(buildDestinationsSection());
|
|
|
|
return sections.join('\n\n');
|
|
}
|
|
|
|
function buildDestinationsSection(): string {
|
|
const all = getAllDestinations();
|
|
|
|
if (all.length === 0) {
|
|
return [
|
|
'## Sending messages',
|
|
'',
|
|
'You currently have no configured destinations. You cannot send messages until an admin wires one up.',
|
|
].join('\n');
|
|
}
|
|
|
|
const lines = ['## Sending messages', ''];
|
|
if (all.length === 1) {
|
|
const d = all[0];
|
|
const label = d.displayName && d.displayName !== d.name ? ` (${d.displayName})` : '';
|
|
lines.push(`Your destination is \`${d.name}\`${label}.`);
|
|
} else {
|
|
lines.push('You can send messages to the following destinations:', '');
|
|
for (const d of all) {
|
|
const label = d.displayName && d.displayName !== d.name ? ` (${d.displayName})` : '';
|
|
lines.push(`- \`${d.name}\`${label}`);
|
|
}
|
|
}
|
|
lines.push('');
|
|
lines.push(
|
|
'Wrap each delivered message in a `<message to="name">…</message>` block; include several blocks in one response to address several destinations. `<internal>…</internal>` marks thinking you don\'t want sent — anything outside these tags is also treated as scratchpad.',
|
|
);
|
|
lines.push('');
|
|
lines.push(
|
|
'When replying to an incoming message, default to addressing the destination it came `from` (every inbound `<message>` tag carries a `from="name"` attribute). Pick a different destination when the request asks for it (e.g., "tell Laura that…").',
|
|
);
|
|
lines.push('');
|
|
lines.push(
|
|
'The `send_message` MCP tool is the same delivery, available mid-turn — handy for a quick acknowledgment ("on it") before a slow tool call. Each `send_message` call and each final-response `<message>` block lands as its own message in the conversation, so they read as a sequence rather than as one combined reply.',
|
|
);
|
|
return lines.join('\n');
|
|
}
|