mirror of
https://github.com/qwibitai/nanoclaw.git
synced 2026-07-12 19:00:58 +08:00
b0c76ce4c5
Scheduled tasks move from MCP tools to a first-class ncl resource:
list / get / create / update / cancel / pause / resume / run / append-log,
with args declared on every verb (strict validation, fix-carrying errors)
and deep per-verb help with executable examples.
A series is CronJob-like: the live (pending/paused) row is the next
occurrence, completed rows are its run history. tasks list reads as a
compact run-history table, server-rendered so the container agent prints
the same aligned table. Short named ids (<slug>-<hex>) are
filesystem/thread-safe and copy-pasteable. Agents keep a per-series work
journal: the run log at tasks/<series>.md (append-log + auto-logged
final text).
Each series runs in its own isolated system session
(system:tasks:<series>); the live-task cap is dropped — isolation
replaces throttling. Spent task sessions are GC'd by the sweep.
--script on a task runs a bash gate BEFORE the agent wakes. It prints a
JSON verdict as its last stdout line: {"wakeAgent": bool, "data": {...}}.
wakeAgent:false handles the occurrence without waking the agent; data is
threaded into the fire's prompt, so a gate can fetch/inspect and hand the
agent exactly what changed. Failing scripts back off exponentially
(2·2^(n-1) min, cap 60) and auto-pause the series after 8 consecutive
failures with a host-written run-log note; manual runs are excluded from
the streak.
BREAKING: the schedule_task / list_tasks / update_task / cancel_task /
pause_task / resume_task MCP tools are removed. Agents schedule via
ncl tasks (available under cli_scope=group). Existing task rows keep
firing — storage (messages_in kind='task') is unchanged; only the
management surface moved. Migration: docs/ncl-tasks-migration.md.
Review round (gavrielc):
- Recurrence frequency guard: create/update refuse a recurrence more
frequent than 4 fires/day with a warning steering to gate scripts;
--dangerously-override-recurrence-limit bypasses after explicit user
confirmation. Counted over the next 24h in the instance TZ. Guarded on
update too, so create-slow-then-update cannot sneak past.
- ncl tasks help scripts: resource help topics (new helpTopics seam on
registerResource) carry the full gate-script guide — contract, examples,
state, failure/backoff semantics, testing directions.
- Agent-facing scheduling instructions slimmed: no recurring-frequency
prose in the fragment; one pointer to the help topic.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
127 lines
3.8 KiB
TypeScript
127 lines
3.8 KiB
TypeScript
import { execFile } from 'node:child_process';
|
|
import fs from 'node:fs';
|
|
import path from 'node:path';
|
|
import type { MessageInRow } from '../db/messages-in.js';
|
|
import { touchHeartbeat } from '../db/connection.js';
|
|
|
|
const SCRIPT_TIMEOUT_MS = 30_000;
|
|
const SCRIPT_MAX_BUFFER = 1024 * 1024;
|
|
|
|
export interface ScriptResult {
|
|
wakeAgent: boolean;
|
|
data?: unknown;
|
|
}
|
|
|
|
function log(msg: string): void {
|
|
console.error(`[task-script] ${msg}`);
|
|
}
|
|
|
|
export async function runScript(script: string, taskId: string): Promise<ScriptResult | null> {
|
|
const scriptPath = path.join('/tmp', `task-script-${taskId}.sh`);
|
|
fs.writeFileSync(scriptPath, script, { mode: 0o755 });
|
|
|
|
return new Promise((resolve) => {
|
|
execFile(
|
|
'bash',
|
|
[scriptPath],
|
|
{ timeout: SCRIPT_TIMEOUT_MS, maxBuffer: SCRIPT_MAX_BUFFER, env: process.env },
|
|
(error, stdout, stderr) => {
|
|
try {
|
|
fs.unlinkSync(scriptPath);
|
|
} catch {
|
|
/* best-effort cleanup */
|
|
}
|
|
|
|
if (stderr) {
|
|
log(`[${taskId}] stderr: ${stderr.slice(0, 500)}`);
|
|
}
|
|
|
|
if (error) {
|
|
log(`[${taskId}] error: ${error.message}`);
|
|
return resolve(null);
|
|
}
|
|
|
|
const lines = stdout.trim().split('\n');
|
|
const lastLine = lines[lines.length - 1];
|
|
if (!lastLine) {
|
|
log(`[${taskId}] no output`);
|
|
return resolve(null);
|
|
}
|
|
|
|
try {
|
|
const result = JSON.parse(lastLine);
|
|
if (typeof result.wakeAgent !== 'boolean') {
|
|
log(`[${taskId}] output missing wakeAgent boolean: ${lastLine.slice(0, 200)}`);
|
|
return resolve(null);
|
|
}
|
|
resolve(result as ScriptResult);
|
|
} catch {
|
|
log(`[${taskId}] output is not valid JSON: ${lastLine.slice(0, 200)}`);
|
|
resolve(null);
|
|
}
|
|
},
|
|
);
|
|
});
|
|
}
|
|
|
|
/** Why a script gated its task: deliberate wakeAgent=false vs a broken script. */
|
|
export type ScriptSkipReason = 'gated' | 'error';
|
|
|
|
export interface TaskScriptOutcome {
|
|
keep: MessageInRow[];
|
|
skipped: Array<{ id: string; reason: ScriptSkipReason }>;
|
|
}
|
|
|
|
/**
|
|
* Run pre-task scripts for any task messages that carry one, serially.
|
|
* - Errors / missing output / wakeAgent=false → task id added to `skipped`,
|
|
* with the reason. The caller acks these as script-skips (not plain
|
|
* completions) so the host can count consecutive failures and back off.
|
|
* - wakeAgent=true → content JSON is mutated to carry `scriptOutput`, so the
|
|
* formatter renders it into the prompt.
|
|
* Non-task messages and tasks without scripts pass through unchanged.
|
|
*/
|
|
export async function applyPreTaskScripts(messages: MessageInRow[]): Promise<TaskScriptOutcome> {
|
|
const keep: MessageInRow[] = [];
|
|
const skipped: Array<{ id: string; reason: ScriptSkipReason }> = [];
|
|
|
|
for (const msg of messages) {
|
|
if (msg.kind !== 'task') {
|
|
keep.push(msg);
|
|
continue;
|
|
}
|
|
|
|
let content: Record<string, unknown>;
|
|
try {
|
|
content = JSON.parse(msg.content);
|
|
} catch {
|
|
keep.push(msg);
|
|
continue;
|
|
}
|
|
|
|
const script = typeof content.script === 'string' ? (content.script as string) : null;
|
|
if (!script) {
|
|
keep.push(msg);
|
|
continue;
|
|
}
|
|
|
|
log(`running script for task ${msg.id}`);
|
|
touchHeartbeat();
|
|
const result = await runScript(script, msg.id);
|
|
touchHeartbeat();
|
|
|
|
if (!result || !result.wakeAgent) {
|
|
const reason: ScriptSkipReason = result ? 'gated' : 'error';
|
|
log(`task ${msg.id} skipped: ${reason === 'gated' ? 'wakeAgent=false' : 'script error/no output'}`);
|
|
skipped.push({ id: msg.id, reason });
|
|
continue;
|
|
}
|
|
|
|
log(`task ${msg.id} wakeAgent=true, enriching prompt`);
|
|
content.scriptOutput = result.data ?? null;
|
|
keep.push({ ...msg, content: JSON.stringify(content) });
|
|
}
|
|
|
|
return { keep, skipped };
|
|
}
|