From 995afae9dbddac7d17ebad34fdc71a8ff3d0e505 Mon Sep 17 00:00:00 2001 From: Ompragash Viswanathan Date: Thu, 31 Jul 2025 16:46:35 +0530 Subject: [PATCH] Add signing support via cosign --- docker.go | 5 +---- docker/docker/Dockerfile.windows.amd64.1809 | 3 +-- docker/docker/Dockerfile.windows.amd64.ltsc2022 | 3 +-- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/docker.go b/docker.go index aa967e1..1f71cd2 100644 --- a/docker.go +++ b/docker.go @@ -843,14 +843,11 @@ func commandCosignSign(build Build, tag string, cosign CosignConfig) *exec.Cmd { args = append(args, "--key", cosign.PrivateKey) } - // Set password and non-interactive environment variables + // Set password environment variable if provided if cosign.Password != "" { os.Setenv("COSIGN_PASSWORD", cosign.Password) } - // Set COSIGN_YES for additional non-interactive assurance - os.Setenv("COSIGN_YES", "true") - // Add custom parameters (after our defaults so users can override) if cosign.Params != "" { extraArgs := strings.Fields(cosign.Params) diff --git a/docker/docker/Dockerfile.windows.amd64.1809 b/docker/docker/Dockerfile.windows.amd64.1809 index 0d488d5..f85891d 100644 --- a/docker/docker/Dockerfile.windows.amd64.1809 +++ b/docker/docker/Dockerfile.windows.amd64.1809 @@ -26,8 +26,7 @@ LABEL maintainer="Drone.IO Community " ` RUN mkdir C:\bin # Install cosign for container image signing -RUN powershell -Command \ - "Invoke-WebRequest 'https://github.com/sigstore/cosign/releases/latest/download/cosign-windows-amd64.exe' -OutFile 'C:\bin\cosign.exe'" +RUN powershell -Command "Invoke-WebRequest 'https://github.com/sigstore/cosign/releases/latest/download/cosign-windows-amd64.exe' -OutFile 'C:\bin\cosign.exe'" COPY --from=download /windows/system32/netapi32.dll /windows/system32/netapi32.dll COPY --from=download /app/docker.exe C:/bin/docker.exe diff --git a/docker/docker/Dockerfile.windows.amd64.ltsc2022 b/docker/docker/Dockerfile.windows.amd64.ltsc2022 index 56115a1..c891e16 100644 --- a/docker/docker/Dockerfile.windows.amd64.ltsc2022 +++ b/docker/docker/Dockerfile.windows.amd64.ltsc2022 @@ -24,8 +24,7 @@ LABEL maintainer="Drone.IO Community " ` RUN mkdir C:\bin # Install cosign for container image signing -RUN powershell -Command \ - "Invoke-WebRequest 'https://github.com/sigstore/cosign/releases/latest/download/cosign-windows-amd64.exe' -OutFile 'C:\bin\cosign.exe'" +RUN powershell -Command "Invoke-WebRequest 'https://github.com/sigstore/cosign/releases/latest/download/cosign-windows-amd64.exe' -OutFile 'C:\bin\cosign.exe'" COPY --from=download /windows/system32/netapi32.dll /windows/system32/netapi32.dll COPY --from=download /app/docker.exe C:/bin/docker.exe