From a367d8be06fdf28ff5bf34d2cc23589cc54cf498 Mon Sep 17 00:00:00 2001 From: Patrick Jahns Date: Tue, 25 Sep 2018 16:29:22 +0200 Subject: [PATCH 1/2] fixed typo regards to sha checksumming --- main.go | 8 ++++---- plugin.go | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/main.go b/main.go index 1c18e30..b656ae3 100644 --- a/main.go +++ b/main.go @@ -57,9 +57,9 @@ func main() { EnvVar: "PLUGIN_MD5", }, cli.StringFlag{ - Name: "sha265-checksum", - Usage: "checksum in sha265 format", - EnvVar: "PLUGIN_SHA265", + Name: "sha256-checksum", + Usage: "checksum in sha256 format", + EnvVar: "PLUGIN_SHA256", }, } @@ -78,7 +78,7 @@ func run(c *cli.Context) error { Password: c.String("password"), SkipVerify: c.Bool("skip-verify"), MD5: c.String("md5-checksum"), - SHA265: c.String("sha265-checksum"), + SHA256: c.String("sha256-checksum"), }, } diff --git a/plugin.go b/plugin.go index 69c8335..02107c5 100644 --- a/plugin.go +++ b/plugin.go @@ -26,7 +26,7 @@ type ( Password string SkipVerify bool MD5 string - SHA265 string + SHA256 string } Plugin struct { @@ -121,7 +121,7 @@ func (p Plugin) Exec() error { } } - if p.Config.SHA265 != "" { + if p.Config.SHA256 != "" { h := sha256.New() if _, err := io.Copy(h, resp.Body); err != nil { @@ -131,7 +131,7 @@ func (p Plugin) Exec() error { check := fmt.Sprintf("%x", h.Sum(nil)) if p.Config.MD5 != check { - return fmt.Errorf("checksum doesn't match, got %s and expected %s", check, p.Config.SHA265) + return fmt.Errorf("checksum doesn't match, got %s and expected %s", check, p.Config.SHA256) } } From 77d760c2b90d892726365128499a7f3ac7decaf9 Mon Sep 17 00:00:00 2001 From: Patrick Jahns Date: Tue, 25 Sep 2018 19:33:31 +0200 Subject: [PATCH 2/2] provide legacy fallback option to avoid breaking changes --- main.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.go b/main.go index b656ae3..63d1f00 100644 --- a/main.go +++ b/main.go @@ -59,7 +59,7 @@ func main() { cli.StringFlag{ Name: "sha256-checksum", Usage: "checksum in sha256 format", - EnvVar: "PLUGIN_SHA256", + EnvVar: "PLUGIN_SHA256,PLUGIN_SHA265", }, }