diff --git a/main.go b/main.go index 568d2c3..3d62049 100644 --- a/main.go +++ b/main.go @@ -159,7 +159,7 @@ func main() { EnvVar: "PLUGIN_UPDATE_DEPENDENCIES,UPDATE_DEPENDENCIES", }, cli.StringFlag{ - Name: "stable-repo-url", + Name: "stable_repo_url", Usage: "URL for stable repository (default 'https://kubernetes-charts.storage.googleapis.com')", EnvVar: "PLUGIN_STABLE_REPO_URL,STABLE_REPO_URL", }, diff --git a/plugin/plugin.go b/plugin/plugin.go index 8f8592b..80232fb 100644 --- a/plugin/plugin.go +++ b/plugin/plugin.go @@ -399,6 +399,7 @@ func (p *Plugin) debug() { fmt.Printf("Secrets: %s \n", p.Config.Secrets) fmt.Printf("Helm Repos: %s \n", p.Config.HelmRepos) fmt.Printf("ValuesFiles: %s \n", p.Config.ValuesFiles) + fmt.Printf("StableRepoURL: %s \n", p.Config.StableRepoURL) kubeconfig, err := ioutil.ReadFile(KUBECONFIG) if err == nil { fmt.Println(string(kubeconfig)) diff --git a/plugin/plugin_test.go b/plugin/plugin_test.go index 9d57502..7180aea 100644 --- a/plugin/plugin_test.go +++ b/plugin/plugin_test.go @@ -573,11 +573,7 @@ func TestHelmInitByAliyunStableRepo(t *testing.T) { } init := doHelmInit(plugin) result := strings.Join(init, " ") - expected := "init " - if plugin.Config.StableRepoURL != "" { - expected = expected + "--stable-repo-url" - } - + expected := "init --stable-repo-url " + plugin.Config.StableRepoURL if expected != result { t.Error("Helm cannot init for stable repository") }