fix: [CI-14845]: support for build args which has comma seperated values

cmd/kaniko-ecr/custom_string_slice.go

@@ -0,0 +1,33 @@
+package main
+
+import (
+	"strings"
+)
+
+// CustomStringSliceFlag is like a regular StringSlice flag but with
+// semicolon as a delimiter
+type CustomStringSliceFlag struct {
+	Value []string
+}
+
+func (f *CustomStringSliceFlag) GetValue() []string {
+	if f.Value == nil {
+		return make([]string, 0)
+	}
+	return f.Value
+}
+
+func (f *CustomStringSliceFlag) String() string {
+	if f.Value == nil {
+		return ""
+	}
+	return strings.Join(f.Value, ";")
+}
+
+func (f *CustomStringSliceFlag) Set(v string) error {
+	for _, s := range strings.Split(v, ";") {
+		s = strings.TrimSpace(s)
+		f.Value = append(f.Value, s)
+	}
+	return nil
+}

cmd/kaniko-ecr/main.go

@@ -125,6 +125,17 @@ func main() {
 			Usage:  "build args",
 			EnvVar: "PLUGIN_BUILD_ARGS",
 		},
+		cli.GenericFlag{
+			Name:   "args-new",
+			Usage:  "build args new",
+			EnvVar: "PLUGIN_BUILD_ARGS_NEW",
+			Value:  new(CustomStringSliceFlag),
+		},
+		cli.BoolFlag{
+			Name:   "plugin-multiple-build-agrs",
+			Usage:  "plugin multiple build agrs",
+			EnvVar: "PLUGIN_MULTIPLE_BUILD_ARGS",
+		},
 		cli.StringFlag{
 			Name:   "target",
 			Usage:  "build target",
@@ -464,6 +475,8 @@ func run(c *cli.Context) error {
 			AutoTagSuffix:               c.String("auto-tag-suffix"),
 			ExpandTag:                   c.Bool("expand-tag"),
 			Args:                        c.StringSlice("args"),
+			ArgsNew:                     c.Generic("args-new").(*CustomStringSliceFlag).GetValue(),
+			IsMultipleBuildArgs:         c.Bool("plugin-multiple-build-agrs"),
 			Target:                      c.String("target"),
 			Repo:                        fmt.Sprintf("%s/%s", c.String("registry"), c.String("repo")),
 			Mirrors:                     c.StringSlice("registry-mirrors"),

kaniko.go

@@ -16,30 +16,32 @@ import (
 type (
 	// Build defines Docker build parameters.
 	Build struct {
-		DroneCommitRef   string   // Drone git commit reference
+		DroneCommitRef      string   // Drone git commit reference
-		DroneRepoBranch  string   // Drone repo branch
+		DroneRepoBranch     string   // Drone repo branch
-		Dockerfile       string   // Docker build Dockerfile
+		Dockerfile          string   // Docker build Dockerfile
-		Context          string   // Docker build context
+		Context             string   // Docker build context
-		Tags             []string // Docker build tags
+		Tags                []string // Docker build tags
-		AutoTag          bool     // Set this to auto detect tags from git commits and semver-tagged labels
+		AutoTag             bool     // Set this to auto detect tags from git commits and semver-tagged labels
-		AutoTagSuffix    string   // Suffix to append to the auto detect tags
+		AutoTagSuffix       string   // Suffix to append to the auto detect tags
-		ExpandTag        bool     // Set this to expand the `Tags` into semver-tagged labels
+		ExpandTag           bool     // Set this to expand the `Tags` into semver-tagged labels
-		Args             []string // Docker build args
+		Args                []string // Docker build args
-		Target           string   // Docker build target
+		ArgsNew             []string // docker build args with comma seperated values
-		Repo             string   // Docker build repository
+		IsMultipleBuildArgs bool     // env variable for fallback for docker build args
-		Mirrors          []string // Docker repository mirrors
+		Target              string   // Docker build target
-		Labels           []string // Label map
+		Repo                string   // Docker build repository
-		SkipTlsVerify    bool     // Docker skip tls certificate verify for registry
+		Mirrors             []string // Docker repository mirrors
-		SnapshotMode     string   // Kaniko snapshot mode
+		Labels              []string // Label map
-		EnableCache      bool     // Whether to enable kaniko cache
+		SkipTlsVerify       bool     // Docker skip tls certificate verify for registry
-		CacheRepo        string   // Remote repository that will be used to store cached layers
+		SnapshotMode        string   // Kaniko snapshot mode
-		CacheTTL         int      // Cache timeout in hours
+		EnableCache         bool     // Whether to enable kaniko cache
-		DigestFile       string   // Digest file location
+		CacheRepo           string   // Remote repository that will be used to store cached layers
-		NoPush           bool     // Set this flag if you only want to build the image, without pushing to a registry
+		CacheTTL            int      // Cache timeout in hours
-		Verbosity        string   // Log level
+		DigestFile          string   // Digest file location
-		Platform         string   // Allows to build with another default platform than the host, similarly to docker build --platform
+		NoPush              bool     // Set this flag if you only want to build the image, without pushing to a registry
-		SkipUnusedStages bool     // Build only used stages
+		Verbosity           string   // Log level
-		TarPath          string   // Set this flag to save the image as a tarball at path
+		Platform            string   // Allows to build with another default platform than the host, similarly to docker build --platform
+		SkipUnusedStages    bool     // Build only used stages
+		TarPath             string   // Set this flag to save the image as a tarball at path
 
 		Cache                       bool   // Enable or disable caching during the build process.
 		CacheDir                    string // Directory to store cached layers.
@@ -202,8 +204,14 @@ func (p Plugin) Exec() error {
 	}
 
 	// Set the build arguments
-	for _, arg := range p.Build.Args {
+	if p.Build.IsMultipleBuildArgs {
-		cmdArgs = append(cmdArgs, fmt.Sprintf("--build-arg=%s", arg))
+		for _, arg := range p.Build.ArgsNew {
+			cmdArgs = append(cmdArgs, "--build-arg", arg)
+		}
+	} else {
+		for _, arg := range p.Build.Args {
+			cmdArgs = append(cmdArgs, "--build-arg", arg)
+		}
 	}
 	// Set the labels
 	for _, label := range p.Build.Labels {