Refactor pushall to use a single loop

pushall

@@ -2,30 +2,25 @@
 
 set -e
 set -u
+set -o pipefail
 
 DISTS="jessie
 unstable
+latest
 "
 
 BASENAME=bitnami/minideb
 GCR_BASENAME=gcr.io/bitnami-containers/minideb
 
-if [ -n "$DOCKER_PASSWORD" ]; then
+if [ -n "${DOCKER_PASSWORD:-}" ]; then
     docker login -u $DOCKER_USERNAME -p $DOCKER_PASSWORD
 fi
 
+if [ -n "${GCR_KEY:-}" ]; then
+    gcloud auth activate-service-account $GCR_EMAIL --key-file <(echo "$GCR_KEY")
+fi
+
 for DIST in $DISTS; do
     docker push $BASENAME:$DIST
-done
-docker push $BASENAME:latest
-
-if [ -n "$GCR_KEY" ]; then
-    echo "$GCR_KEY" > keyfile.json
-    gcloud auth activate-service-account $GCR_EMAIL --key-file keyfile.json
-fi
-
-for DIST in $DISTS; do
     gcloud docker push $GCR_BASENAME:$DIST
 done
-gcloud docker push $GCR_BASENAME:latest
-