mirror of
https://github.com/qwibitai/nanoclaw.git
synced 2026-06-12 18:11:51 +08:00
57a6491c7e
- Add three-level isolation model (shared session, same agent, separate agent) with agent-shared session mode for cross-channel shared sessions - Create /manage-channels skill for wiring channels to agent groups - Refactor all 12 v2 channel skills: lean SKILL.md + VERIFY.md + REMOVE.md with structured Channel Info section for platform-specific metadata - Create /add-discord-v2 skill (was missing) - Add step 5a to setup SKILL.md invoking /manage-channels after channel install - Update setup/verify.ts to check all 12 channel token types - Add docs/v2-isolation-model.md explaining the isolation model - Update v2-checklist.md and v2-setup-wiring.md to reflect completed work Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
99 lines
5.4 KiB
Markdown
99 lines
5.4 KiB
Markdown
# v2 Setup Wiring — Status & Remaining Work
|
|
|
|
Last updated: 2026-04-09, branch `v2`, commit `1dc5750`
|
|
|
|
## What's Done
|
|
|
|
### Two-DB Split (session DB write isolation)
|
|
- Session DB split into `inbound.db` (host-owned) and `outbound.db` (container-owned)
|
|
- Each file has exactly one writer — eliminates SQLite write contention across host-container mount
|
|
- Host uses even seq numbers, container uses odd (collision-free)
|
|
- Container heartbeat via file touch (`/workspace/.heartbeat`) instead of DB UPDATE
|
|
- Scheduling MCP tools emit system actions via messages_out; host applies them to inbound.db in `delivery.ts:handleSystemAction()`
|
|
- Host sweep reads `processing_ack` table + heartbeat file mtime for stale detection
|
|
- Container clears stale `processing_ack` entries on startup (crash recovery)
|
|
- Files: `src/db/schema.ts` (INBOUND_SCHEMA + OUTBOUND_SCHEMA), `src/session-manager.ts`, `src/delivery.ts`, `src/host-sweep.ts`, `container/agent-runner/src/db/connection.ts`, `messages-in.ts`, `messages-out.ts`, `poll-loop.ts`, `mcp-tools/scheduling.ts`, `mcp-tools/interactive.ts`
|
|
- Container image rebuilt with tsconfig excluding v1 (`container/agent-runner/tsconfig.json`)
|
|
- E2E verified: host → Docker container → Claude responds → "E2E works!" ✓
|
|
|
|
### OneCLI Integration
|
|
- `ensureAgent()` call added before `applyContainerConfig()` in `src/container-runner.ts`
|
|
- Without `ensureAgent`, OneCLI rejects unknown agent identifiers and returns false, leaving container with no credentials
|
|
- E2E verified with OneCLI credential injection ✓
|
|
|
|
### Channel Barrel
|
|
- `src/index.ts` imports `./channels/index.js` (the barrel)
|
|
- Channel skills uncomment lines in the barrel to enable channels
|
|
- Discord is uncommented by default (it was previously a direct import in index.ts)
|
|
|
|
### Setup Registration (partially)
|
|
- `setup/register.ts` rewritten to create v2 entities (`agent_groups`, `messaging_groups`, `messaging_group_agents`) in `data/v2.db`
|
|
- Accepts `--platform-id` (v2) and `--jid` (v1 compat) flags
|
|
- Added `getMessagingGroupAgentByPair()` to prevent duplicate wiring
|
|
- `setup/verify.ts` updated to check v2 central DB (counts agent groups with wiring)
|
|
|
|
### Router Logging
|
|
- `src/router.ts` logs `MESSAGE DROPPED` at WARN level when no agents wired, with actionable guidance
|
|
|
|
---
|
|
|
|
## Previously Open — Now Resolved
|
|
|
|
### 1. ~~v2 Channel Skills Don't Register Groups~~ ✅
|
|
|
|
Channel skills now point to `/manage-channels` in their "Next Steps" section. Registration is handled by the `/manage-channels` skill, which reads each channel's `## Channel Info` section for platform-specific guidance. Channel skills stay lean (credentials only).
|
|
|
|
### 2. ~~v1 add-discord Skill is Incompatible~~ ✅
|
|
|
|
Created `/add-discord-v2` skill matching the v2 pattern. Setup SKILL.md updated to reference `/add-discord-v2`.
|
|
|
|
### 3. ~~Setup SKILL.md Missing Group Registration Step~~ ✅
|
|
|
|
Added step 5a "Wire Channels to Agent Groups" between channel installation (step 5) and mount allowlist (step 6). This step invokes `/manage-channels` which handles agent group creation, isolation level decisions, and wiring.
|
|
|
|
### 4. ~~Channel Skills Should Know Channel Type~~ ✅
|
|
|
|
Each v2 channel skill now has a `## Channel Info` structured section with: type, terminology, how-to-find-id, supports-threads, typical-use, default-isolation. The `/manage-channels` skill reads this for contextual recommendations.
|
|
|
|
### 5. ~~Verify Step Channel Auth Check~~ ✅
|
|
|
|
`setup/verify.ts` now checks all v2 channel tokens: DISCORD_BOT_TOKEN, TELEGRAM_BOT_TOKEN, SLACK_BOT_TOKEN+SLACK_APP_TOKEN, GITHUB_TOKEN, LINEAR_API_KEY, GCHAT_CREDENTIALS, TEAMS_APP_ID+TEAMS_APP_PASSWORD, WEBEX_BOT_TOKEN, MATRIX_ACCESS_TOKEN, RESEND_API_KEY, WHATSAPP_ACCESS_TOKEN, IMESSAGE_ENABLED, plus WhatsApp Baileys auth dir.
|
|
|
|
### 6. Agent-Shared Session Mode ✅
|
|
|
|
Added `session_mode: 'agent-shared'` for cross-channel shared sessions (e.g. GitHub + Slack in one conversation). Session resolution looks up by agent_group_id instead of messaging_group_id when this mode is set.
|
|
|
|
---
|
|
|
|
## Architecture Reference
|
|
|
|
### v2 Entity Model
|
|
```
|
|
agent_groups (id, name, folder, is_admin, agent_provider, container_config)
|
|
↕ many-to-many
|
|
messaging_groups (id, channel_type, platform_id, name, is_group, admin_user_id)
|
|
via
|
|
messaging_group_agents (messaging_group_id, agent_group_id, trigger_rules, session_mode, priority)
|
|
```
|
|
|
|
### Message Flow
|
|
```
|
|
Channel adapter → routeInbound() → resolve messaging_group → resolve agent via messaging_group_agents
|
|
→ resolve/create session → write to inbound.db → wake container → agent-runner polls inbound.db
|
|
→ agent responds → writes to outbound.db → host delivery poll reads outbound.db → deliver via adapter
|
|
```
|
|
|
|
### Key Files
|
|
| File | Purpose |
|
|
|------|---------|
|
|
| `src/index.ts` | v2 entry point, imports channel barrel |
|
|
| `src/channels/index.ts` | Channel barrel — uncomment to enable |
|
|
| `src/router.ts` | Inbound routing, auto-creates messaging groups |
|
|
| `src/session-manager.ts` | Creates inbound.db + outbound.db per session |
|
|
| `src/delivery.ts` | Polls outbound.db, delivers, handles system actions |
|
|
| `src/host-sweep.ts` | Syncs processing_ack, stale detection, recurrence |
|
|
| `src/container-runner.ts` | Spawns containers, OneCLI ensureAgent + applyContainerConfig |
|
|
| `setup/register.ts` | Creates v2 entities (agent_group, messaging_group, wiring) |
|
|
| `setup/verify.ts` | Checks v2 central DB for registered groups |
|
|
| `container/agent-runner/src/db/connection.ts` | Two-DB connection layer (inbound read-only, outbound read-write) |
|