Merge pull request #11 from drone-plugins/checksum-fix

Copy the target file first and fix checksum checks

.appveyor.yml

@@ -45,7 +45,7 @@ deploy_script:
       if ( $env:APPVEYOR_PULL_REQUEST_NUMBER ) {
         Write-Host Nothing to deploy.
       } else {
-        docker login --username $env:DOCKER_USERNAME --password $env:DOCKER_PASSWORD
+        echo $env:DOCKER_PASSWORD | docker login --username $env:DOCKER_USERNAME --password-stdin
 
         if ( $env:APPVEYOR_REPO_TAG -eq 'true' ) {
           $major,$minor,$patch = $env:APPVEYOR_REPO_TAG_NAME.substring(1).split('.')

main.go

@@ -31,6 +31,11 @@ func main() {
 			Usage:  "destination for the download",
 			EnvVar: "PLUGIN_DESTINATION",
 		},
+		cli.StringFlag{
+			Name:   "authorization",
+			Usage:  "value to send in the authorization header",
+			EnvVar: "PLUGIN_AUTHORIZATION,DOWNLOAD_AUTHORIZATION",
+		},
 		cli.StringFlag{
 			Name:   "username",
 			Usage:  "username for basic auth",
@@ -52,9 +57,9 @@ func main() {
 			EnvVar: "PLUGIN_MD5",
 		},
 		cli.StringFlag{
-			Name:   "sha265-checksum",
-			Usage:  "checksum in sha265 format",
-			EnvVar: "PLUGIN_SHA265",
+			Name:   "sha256-checksum",
+			Usage:  "checksum in sha256 format",
+			EnvVar: "PLUGIN_SHA256,PLUGIN_SHA265",
 		},
 	}
 
@@ -66,13 +71,14 @@ func main() {
 func run(c *cli.Context) error {
 	plugin := Plugin{
 		Config: Config{
-			Source:      c.String("source"),
-			Destination: c.String("destination"),
-			Username:    c.String("username"),
-			Password:    c.String("password"),
-			SkipVerify:  c.Bool("skip-verify"),
-			MD5:         c.String("md5-checksum"),
-			SHA265:      c.String("sha265-checksum"),
+			Source:        c.String("source"),
+			Destination:   c.String("destination"),
+			Authorization: c.String("authorization"),
+			Username:      c.String("username"),
+			Password:      c.String("password"),
+			SkipVerify:    c.Bool("skip-verify"),
+			MD5:           c.String("md5-checksum"),
+			SHA256:        c.String("sha256-checksum"),
 		},
 	}
 

plugin.go

@@ -19,13 +19,14 @@ import (
 
 type (
 	Config struct {
-		Source      string
-		Destination string
-		Username    string
-		Password    string
-		SkipVerify  bool
-		MD5         string
-		SHA265      string
+		Source        string
+		Destination   string
+		Authorization string
+		Username      string
+		Password      string
+		SkipVerify    bool
+		MD5           string
+		SHA256        string
 	}
 
 	Plugin struct {
@@ -57,6 +58,15 @@ func (p Plugin) Exec() error {
 				InsecureSkipVerify: p.Config.SkipVerify,
 			},
 		},
+		CheckRedirect: func(req *http.Request, via []*http.Request) error {
+			if p.Config.Username != "" && p.Config.Password != "" {
+				req.SetBasicAuth(p.Config.Username, p.Config.Password)
+			}
+			if p.Config.Authorization != "" {
+				req.Header.Add("Authorization", p.Config.Authorization)
+			}
+			return nil
+		},
 	}
 
 	req, err := http.NewRequest(
@@ -73,6 +83,10 @@ func (p Plugin) Exec() error {
 		req.SetBasicAuth(p.Config.Username, p.Config.Password)
 	}
 
+	if p.Config.Authorization != "" {
+		req.Header.Add("Authorization", p.Config.Authorization)
+	}
+
 	resp, err := client.Do(req)
 
 	if err != nil {
@@ -81,6 +95,10 @@ func (p Plugin) Exec() error {
 
 	defer resp.Body.Close()
 
+	if resp.StatusCode != http.StatusOK {
+		return errors.Errorf("request failed, status %s", http.StatusText(resp.StatusCode))
+	}
+
 	target, err := os.Create(destination)
 
 	if err != nil {
@@ -89,39 +107,45 @@ func (p Plugin) Exec() error {
 
 	defer target.Close()
 
-	if p.Config.MD5 != "" {
-		h := md5.New()
-
-		if _, err := io.Copy(h, resp.Body); err != nil {
-			return errors.Wrap(err, "failed to compare checksum")
-		}
-
-		check := fmt.Sprintf("%x", h.Sum(nil))
-
-		if p.Config.MD5 != check {
-			return fmt.Errorf("checksum doesn't match, got %s and expected %s", check, p.Config.MD5)
-		}
-	}
-
-	if p.Config.SHA265 != "" {
-		h := sha256.New()
-
-		if _, err := io.Copy(h, resp.Body); err != nil {
-			return errors.Wrap(err, "failed to compare checksum")
-		}
-
-		check := fmt.Sprintf("%x", h.Sum(nil))
-
-		if p.Config.MD5 != check {
-			return fmt.Errorf("checksum doesn't match, got %s and expected %s", check, p.Config.SHA265)
-		}
-	}
-
 	_, err = io.Copy(target, resp.Body)
 
 	if err != nil {
 		return errors.Wrap(err, "copying destination failed")
 	}
 
+	if p.Config.MD5 != "" {
+		h := md5.New()
+		target.Seek(0, 0)
+
+		if _, err := io.Copy(h, target); err != nil {
+			defer os.Remove(target.Name())
+			return errors.Wrap(err, "failed to compare checksum")
+		}
+
+		check := fmt.Sprintf("%x", h.Sum(nil))
+
+		if p.Config.MD5 != check {
+			defer os.Remove(target.Name())
+			return fmt.Errorf("checksum doesn't match, got %s and expected %s", check, p.Config.MD5)
+		}
+	}
+
+	if p.Config.SHA256 != "" {
+		h := sha256.New()
+		target.Seek(0, 0)
+
+		if _, err := io.Copy(h, target); err != nil {
+			defer os.Remove(target.Name())
+			return errors.Wrap(err, "failed to compare checksum")
+		}
+
+		check := fmt.Sprintf("%x", h.Sum(nil))
+
+		if p.Config.SHA256 != check {
+			defer os.Remove(target.Name())
+			return fmt.Errorf("checksum doesn't match, got %s and expected %s", check, p.Config.SHA256)
+		}
+	}
+
 	return nil
 }