Merge pull request #11 from drone-plugins/checksum-fix

Copy the target file first and fix checksum checks

main.go

@@ -57,9 +57,9 @@ func main() {
 			EnvVar: "PLUGIN_MD5",
 		},
 		cli.StringFlag{
-			Name:   "sha265-checksum",
-			Usage:  "checksum in sha265 format",
-			EnvVar: "PLUGIN_SHA265",
+			Name:   "sha256-checksum",
+			Usage:  "checksum in sha256 format",
+			EnvVar: "PLUGIN_SHA256,PLUGIN_SHA265",
 		},
 	}
 
@@ -78,7 +78,7 @@ func run(c *cli.Context) error {
 			Password:      c.String("password"),
 			SkipVerify:    c.Bool("skip-verify"),
 			MD5:           c.String("md5-checksum"),
-			SHA265:        c.String("sha265-checksum"),
+			SHA256:        c.String("sha256-checksum"),
 		},
 	}
 

plugin.go

@@ -26,7 +26,7 @@ type (
 		Password      string
 		SkipVerify    bool
 		MD5           string
-		SHA265        string
+		SHA256        string
 	}
 
 	Plugin struct {
@@ -107,39 +107,45 @@ func (p Plugin) Exec() error {
 
 	defer target.Close()
 
-	if p.Config.MD5 != "" {
-		h := md5.New()
-
-		if _, err := io.Copy(h, resp.Body); err != nil {
-			return errors.Wrap(err, "failed to compare checksum")
-		}
-
-		check := fmt.Sprintf("%x", h.Sum(nil))
-
-		if p.Config.MD5 != check {
-			return fmt.Errorf("checksum doesn't match, got %s and expected %s", check, p.Config.MD5)
-		}
-	}
-
-	if p.Config.SHA265 != "" {
-		h := sha256.New()
-
-		if _, err := io.Copy(h, resp.Body); err != nil {
-			return errors.Wrap(err, "failed to compare checksum")
-		}
-
-		check := fmt.Sprintf("%x", h.Sum(nil))
-
-		if p.Config.MD5 != check {
-			return fmt.Errorf("checksum doesn't match, got %s and expected %s", check, p.Config.SHA265)
-		}
-	}
-
 	_, err = io.Copy(target, resp.Body)
 
 	if err != nil {
 		return errors.Wrap(err, "copying destination failed")
 	}
 
+	if p.Config.MD5 != "" {
+		h := md5.New()
+		target.Seek(0, 0)
+
+		if _, err := io.Copy(h, target); err != nil {
+			defer os.Remove(target.Name())
+			return errors.Wrap(err, "failed to compare checksum")
+		}
+
+		check := fmt.Sprintf("%x", h.Sum(nil))
+
+		if p.Config.MD5 != check {
+			defer os.Remove(target.Name())
+			return fmt.Errorf("checksum doesn't match, got %s and expected %s", check, p.Config.MD5)
+		}
+	}
+
+	if p.Config.SHA256 != "" {
+		h := sha256.New()
+		target.Seek(0, 0)
+
+		if _, err := io.Copy(h, target); err != nil {
+			defer os.Remove(target.Name())
+			return errors.Wrap(err, "failed to compare checksum")
+		}
+
+		check := fmt.Sprintf("%x", h.Sum(nil))
+
+		if p.Config.SHA256 != check {
+			defer os.Remove(target.Name())
+			return fmt.Errorf("checksum doesn't match, got %s and expected %s", check, p.Config.SHA256)
+		}
+	}
+
 	return nil
 }