third/plugin-drone-helm
1
0
Fork 0
mirror of https://github.com/ipedrazas/drone-helm.git synced 2026-06-14 05:12:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #16 from ipedrazas/ns

Browse Source 
Namespace option now works as expected
This commit is contained in:
Ivan Pedrazas
2017-02-06 20:20:05 +00:00
committed by GitHub
parent f043d8b554 d4210c230f
commit 72d9f29ead
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugin.go
+5
View File
@@ -53,6 +53,7 @@ func setPushEventCommand(p *Plugin) {
upgrade := make([]string, 2)
upgrade[0] = "upgrade"
upgrade[1] = "--install"
if p.Config.Release != "" {
upgrade = append(upgrade, p.Config.Release)
}
@@ -61,6 +62,10 @@ func setPushEventCommand(p *Plugin) {
upgrade = append(upgrade, "--set")
upgrade = append(upgrade, p.Config.Values)
}
if p.Config.Namespace != "" {
upgrade = append(upgrade, "--namespace")
upgrade = append(upgrade, p.Config.Namespace)
}
if p.Config.DryRun {
upgrade = append(upgrade, "--dry-run")
}
plugin_test.go
+1 -1
View File
@@ -58,7 +58,7 @@ func TestGetHelmCommand(t *testing.T) {
}
setHelmCommand(plugin)
res := strings.Join(plugin.Config.HelmCommand[:], " ")
expected := "upgrade --install test-release ./chart/test --set image.tag=v.0.1.0,nameOverride=my-over-app --dry-run --debug"
expected := "upgrade --install test-release ./chart/test --set image.tag=v.0.1.0,nameOverride=my-over-app --namespace default --dry-run --debug"
if res != expected {
t.Errorf("Result is %s and we expected %s", res, expected)
}