Compare commits

...

6 Commits

Author SHA1 Message Date
Shubham Agrawal 49309bfa42 Make access key & secret optional in case of iam role usage on EKS cluster 2021-01-20 00:25:23 +05:30
Shubham Agrawal 428642719b Merge pull request #7 from drone/fix_label
Fix label usage
2021-01-18 21:15:01 +05:30
Shubham Agrawal 33f15bdebe Fix label usage 2021-01-18 21:12:53 +05:30
Shubham Agrawal 10df8f28b9 Merge pull request #6 from drone/fix_ecr
Fix kaniko ecr publish
2020-12-02 15:20:00 +05:30
Shubham Agrawal 17072a25f1 Fix ecr publish 2020-12-02 15:17:28 +05:30
Shubham Agrawal 26c93eccd1 Merge pull request #5 from drone/fix_gcr
Fix kaniko-gcr docker file
2020-11-26 23:50:20 +05:30
3 changed files with 13 additions and 16 deletions
+12 -15
View File
@@ -109,7 +109,7 @@ func run(c *cli.Context) error {
Tags: c.StringSlice("tags"),
Args: c.StringSlice("args"),
Target: c.String("target"),
Repo: c.String("repo"),
Repo: fmt.Sprintf("%s/%s", c.String("registry"), c.String("repo")),
Labels: c.StringSlice("custom-labels"),
},
}
@@ -117,28 +117,25 @@ func run(c *cli.Context) error {
}
func setupECRAuth(accessKey, secretKey, registry string) error {
if accessKey == "" {
return fmt.Errorf("Access key must be specified")
}
if secretKey == "" {
return fmt.Errorf("Secret key must be specified")
}
if registry == "" {
return fmt.Errorf("Registry must be specified")
}
err := os.Setenv(accessKeyEnv, accessKey)
if err != nil {
return errors.Wrap(err, fmt.Sprintf("failed to set %s environment variable", accessKeyEnv))
}
// If IAM role is used, access key & secret key are not required
if accessKey != "" && secretKey != "" {
err := os.Setenv(accessKeyEnv, accessKey)
if err != nil {
return errors.Wrap(err, fmt.Sprintf("failed to set %s environment variable", accessKeyEnv))
}
err = os.Setenv(secretKeyEnv, secretKey)
if err != nil {
return errors.Wrap(err, fmt.Sprintf("failed to set %s environment variable", secretKeyEnv))
err = os.Setenv(secretKeyEnv, secretKey)
if err != nil {
return errors.Wrap(err, fmt.Sprintf("failed to set %s environment variable", secretKeyEnv))
}
}
jsonBytes := []byte(fmt.Sprintf(`{"credStore": "ecr-login", "credHelpers": {"%s": "ecr-login"}}`, registry))
err = ioutil.WriteFile(dockerConfigPath, jsonBytes, 0644)
err := ioutil.WriteFile(dockerConfigPath, jsonBytes, 0644)
if err != nil {
return errors.Wrap(err, "failed to create docker config file")
}
+1 -1
View File
@@ -46,7 +46,7 @@ func (p Plugin) Exec() error {
}
// Set the labels
for _, label := range p.Build.Labels {
cmdArgs = append(cmdArgs, fmt.Sprintf("--label %s", label))
cmdArgs = append(cmdArgs, fmt.Sprintf("--label=%s", label))
}
if p.Build.Target != "" {
Regular → Executable
View File