fix: lint error

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

.github/workflows/docker.yml

@@ -6,9 +6,12 @@ on:
       - master
     tags:
       - 'v*'
+  pull_request:
+    branches:
+      - 'master'
 
 jobs:
-  build:
+  build-docker:
     runs-on: ubuntu-latest
     steps:
       - name: Setup go
@@ -23,16 +26,12 @@ jobs:
       - name: Build binary
         run : |
           make build_linux_amd64
-          make build_linux_arm64
           make build_linux_arm
-
-      - name: Check binary
-        run : |
-          ./release/linux/amd64/drone-scp --help
-
+          make build_linux_arm64
       -
         name: Set up QEMU
         uses: docker/setup-qemu-action@v2
+
       -
         name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v2
@@ -53,86 +52,26 @@ jobs:
           password: ${{ secrets.GITHUB_TOKEN }}
 
       -
-        name: Docker meta for linux amd64
-        id: meta-linux-amd64
+        name: Docker meta
+        id: docker-meta
         uses: docker/metadata-action@v4
         with:
-          flavor: |
-            latest=false
-            suffix=linux-amd64
           images: |
-            appleboy/drone-scp
-            ghcr.io/appleboy/drone-scp
+            ${{ github.repository }}
+            ghcr.io/${{ github.repository }}
           tags: |
-            type=raw,value=,enable={{is_default_branch}}
-            type=raw,value=latest,suffix=,enable={{is_default_branch}}
-            type=semver,event=tag,pattern={{version}},suffix=-linux-amd64
-            type=semver,event=tag,pattern={{major}}.{{minor}},suffix=-linux-amd64
-            type=semver,event=tag,pattern={{major}},suffix=-linux-amd64
+            type=raw,value=latest,enable={{is_default_branch}}
+            type=semver,pattern={{version}}
+            type=semver,pattern={{major}}.{{minor}}
+            type=semver,pattern={{major}}
 
       -
-        name: Build and push linux amd64
-        uses: docker/build-push-action@v3
+        name: Build and push
+        uses: docker/build-push-action@v4
         with:
           context: .
-          file: docker/Dockerfile.linux.amd64
-          platforms: linux/amd64
-          push: true
-          tags: ${{ steps.meta-linux-amd64.outputs.tags }}
-          labels: ${{ steps.meta-linux-amd64.outputs.labels }}
-
-      -
-        name: Docker meta for linux arm64
-        id: meta-linux-arm64
-        uses: docker/metadata-action@v4
-        with:
-          flavor: |
-            latest=false
-            suffix=linux-arm64
-          images: |
-            appleboy/drone-scp
-            ghcr.io/appleboy/drone-scp
-          tags: |
-            type=raw,value=,enable={{is_default_branch}}
-            type=semver,event=tag,pattern={{version}},suffix=-linux-arm64
-            type=semver,event=tag,pattern={{major}}.{{minor}},suffix=-linux-arm64
-            type=semver,event=tag,pattern={{major}},suffix=-linux-arm64
-
-      -
-        name: Build and push linux arm64
-        uses: docker/build-push-action@v3
-        with:
-          context: .
-          file: docker/Dockerfile.linux.arm64
-          platforms: linux/arm64
-          push: true
-          tags: ${{ steps.meta-linux-arm64.outputs.tags }}
-          labels: ${{ steps.meta-linux-arm64.outputs.labels }}
-
-      -
-        name: Docker meta for linux arm
-        id: meta-linux-arm
-        uses: docker/metadata-action@v4
-        with:
-          flavor: |
-            latest=false
-            suffix=linux-arm
-          images: |
-            appleboy/drone-scp
-            ghcr.io/appleboy/drone-scp
-          tags: |
-            type=raw,value=,enable={{is_default_branch}}
-            type=semver,event=tag,pattern={{version}},suffix=-linux-arm
-            type=semver,event=tag,pattern={{major}}.{{minor}},suffix=-linux-arm
-            type=semver,event=tag,pattern={{major}},suffix=-linux-arm
-
-      -
-        name: Build and push linux arm
-        uses: docker/build-push-action@v3
-        with:
-          context: .
-          file: docker/Dockerfile.linux.arm
-          platforms: linux/arm
-          push: true
-          tags: ${{ steps.meta-linux-arm.outputs.tags }}
-          labels: ${{ steps.meta-linux-arm.outputs.labels }}
+          platforms: linux/amd64,linux/arm,linux/arm64
+          file: docker/Dockerfile
+          push: ${{ github.event_name != 'pull_request' }}
+          tags: ${{ steps.docker-meta.outputs.tags }}
+          labels: ${{ steps.docker-meta.outputs.labels }}

.github/workflows/lint.yml

@@ -20,18 +20,10 @@ jobs:
           version: latest
           args: --verbose
 
-      - uses: hadolint/hadolint-action@v3.0.0
-        name: hadolint for Dockerfile.linux.amd64
+      - uses: hadolint/hadolint-action@v3.1.0
+        name: hadolint for Dockerfile
         with:
-          dockerfile: docker/Dockerfile.linux.amd64
-      - uses: hadolint/hadolint-action@v3.0.0
-        name: hadolint for Dockerfile.linux.arm64
-        with:
-          dockerfile: docker/Dockerfile.linux.arm64
-      - uses: hadolint/hadolint-action@v3.0.0
-        name: hadolint for Dockerfile.linux.arm
-        with:
-          dockerfile: docker/Dockerfile.linux.arm
+          dockerfile: docker/Dockerfile
 
   testing:
     runs-on: ubuntu-latest

command.go

@@ -0,0 +1,12 @@
+//go:build !windows
+// +build !windows
+
+package main
+
+func rmcmd(target string) string {
+	return "rm -rf " + target
+}
+
+func mkdircmd(target string) string {
+	return "mkdir -p " + target
+}

command_windows.go

@@ -0,0 +1,12 @@
+//go:build windows
+// +build windows
+
+package main
+
+func rmcmd(target string) string {
+	return "DEL /F /S " + target
+}
+
+func mkdircmd(target string) string {
+	return "if not exist " + target + " mkdir " + target
+}

docker/Dockerfile

@@ -1,12 +1,16 @@
-FROM plugins/base:linux-amd64
+FROM alpine:3.17
+
+ARG TARGETOS
+ARG TARGETARCH
 
 LABEL maintainer="Bo-Yi Wu <appleboy.tw@gmail.com>" \
-  org.label-schema.name="Drone SCP" \
+  org.label-schema.name="Git SCP Plugin" \
   org.label-schema.vendor="Bo-Yi Wu" \
   org.label-schema.schema-version="1.0"
 
 RUN apk add --no-cache ca-certificates && \
   rm -rf /var/cache/apk/*
 
-COPY release/linux/amd64/drone-scp /bin/
+COPY release/${TARGETOS}/${TARGETARCH}/drone-scp /bin/
+
 ENTRYPOINT ["/bin/drone-scp"]

docker/Dockerfile.linux.arm

@@ -1,12 +0,0 @@
-FROM plugins/base:linux-arm
-
-LABEL maintainer="Bo-Yi Wu <appleboy.tw@gmail.com>" \
-  org.label-schema.name="Drone SCP" \
-  org.label-schema.vendor="Bo-Yi Wu" \
-  org.label-schema.schema-version="1.0"
-
-RUN apk add --no-cache ca-certificates && \
-  rm -rf /var/cache/apk/*
-
-COPY release/linux/arm/drone-scp /bin/
-ENTRYPOINT ["/bin/drone-scp"]

docker/Dockerfile.linux.arm64

@@ -1,12 +0,0 @@
-FROM plugins/base:linux-arm64
-
-LABEL maintainer="Bo-Yi Wu <appleboy.tw@gmail.com>" \
-  org.label-schema.name="Drone SCP" \
-  org.label-schema.vendor="Bo-Yi Wu" \
-  org.label-schema.schema-version="1.0"
-
-RUN apk add --no-cache ca-certificates && \
-  rm -rf /var/cache/apk/*
-
-COPY release/linux/arm64/drone-scp /bin/
-ENTRYPOINT ["/bin/drone-scp"]

docker/Dockerfile.windows.amd64

@@ -1,10 +0,0 @@
-FROM microsoft/nanoserver:10.0.14393.1884
-
-LABEL maintainer="Bo-Yi Wu <appleboy.tw@gmail.com>" \
-  org.label-schema.name="Drone SCP" \
-  org.label-schema.vendor="Bo-Yi Wu" \
-  org.label-schema.schema-version="1.0"
-
-COPY drone-scp.exe /drone-scp.exe
-
-ENTRYPOINT [ "\\drone-scp.exe" ]

docker/manifest.tmpl

@@ -1,25 +0,0 @@
-image: appleboy/drone-scp:{{#if build.tag}}{{trimPrefix "v" build.tag}}{{else}}latest{{/if}}
-{{#if build.tags}}
-tags:
-{{#each build.tags}}
-  - {{this}}
-{{/each}}
-{{/if}}
-manifests:
-  -
-    image: appleboy/drone-scp:{{#if build.tag}}{{trimPrefix "v" build.tag}}-{{/if}}linux-amd64
-    platform:
-      architecture: amd64
-      os: linux
-  -
-    image: appleboy/drone-scp:{{#if build.tag}}{{trimPrefix "v" build.tag}}-{{/if}}linux-arm64
-    platform:
-      architecture: arm64
-      os: linux
-      variant: v8
-  -
-    image: appleboy/drone-scp:{{#if build.tag}}{{trimPrefix "v" build.tag}}-{{/if}}linux-arm
-    platform:
-      architecture: arm
-      os: linux
-      variant: v7

go.mod

@@ -1,15 +1,15 @@
 module github.com/appleboy/drone-scp
 
-go 1.18
+go 1.20
 
 require (
 	github.com/appleboy/com v0.1.6
 	github.com/appleboy/easyssh-proxy v1.3.9
-	github.com/fatih/color v1.13.0
-	github.com/joho/godotenv v1.4.0
+	github.com/fatih/color v1.14.1
+	github.com/joho/godotenv v1.5.1
 	github.com/stretchr/testify v1.8.1
-	github.com/urfave/cli/v2 v2.23.7
-	golang.org/x/crypto v0.4.0
+	github.com/urfave/cli/v2 v2.24.4
+	golang.org/x/crypto v0.6.0
 )
 
 require (
@@ -22,6 +22,6 @@ require (
 	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/russross/blackfriday/v2 v2.1.0 // indirect
 	github.com/xrash/smetrics v0.0.0-20201216005158-039620a65673 // indirect
-	golang.org/x/sys v0.3.0 // indirect
+	golang.org/x/sys v0.5.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )

go.sum

@@ -12,15 +12,12 @@ github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/dchest/bcrypt_pbkdf v0.0.0-20150205184540-83f37f9c154a h1:saTgr5tMLFnmy/yg3qDTft4rE5DY2uJ/cCxCe3q0XTU=
 github.com/dchest/bcrypt_pbkdf v0.0.0-20150205184540-83f37f9c154a/go.mod h1:Bw9BbhOJVNR+t0jCqx2GC6zv0TGBsShs56Y3gfSCvl0=
-github.com/fatih/color v1.13.0 h1:8LOYc1KYPPmyKMuN8QV2DNRWNbLo6LZ0iLs8+mlH53w=
-github.com/fatih/color v1.13.0/go.mod h1:kLAiJbzzSOZDVNGyDpeOxJ47H46qBXwg5ILebYFFOfk=
-github.com/joho/godotenv v1.4.0 h1:3l4+N6zfMWnkbPEXKng2o2/MR5mSwTrBih4ZEkkz1lg=
-github.com/joho/godotenv v1.4.0/go.mod h1:f4LDr5Voq0i2e/R5DDNOoa2zzDfwtkZa6DnEwAbqwq4=
-github.com/mattn/go-colorable v0.1.9/go.mod h1:u6P/XSegPjTcexA+o6vUJrdnUu04hMope9wVRipJSqc=
+github.com/fatih/color v1.14.1 h1:qfhVLaG5s+nCROl1zJsZRxFeYrHLqWroPOQ8BWiNb4w=
+github.com/fatih/color v1.14.1/go.mod h1:2oHN61fhTpgcxD3TSWCgKDiH1+x4OiDVVGH8WlgGZGg=
+github.com/joho/godotenv v1.5.1 h1:7eLL/+HRGLY0ldzfGMeQkb7vMd0as4CfYvUVzLqw0N0=
+github.com/joho/godotenv v1.5.1/go.mod h1:f4LDr5Voq0i2e/R5DDNOoa2zzDfwtkZa6DnEwAbqwq4=
 github.com/mattn/go-colorable v0.1.13 h1:fFA4WZxdEF4tXPZVKMLwD8oUnCTTo08duU7wxecdEvA=
 github.com/mattn/go-colorable v0.1.13/go.mod h1:7S9/ev0klgBDR4GtXTXX8a3vIGJpMovkB8vQcUbaXHg=
-github.com/mattn/go-isatty v0.0.12/go.mod h1:cbi8OIDigv2wuxKPP5vlRcQ1OAZbq2CE4Kysco4FUpU=
-github.com/mattn/go-isatty v0.0.14/go.mod h1:7GGIvUiUoEMVVmxf/4nioHXj79iQHKdU27kJ6hsGG94=
 github.com/mattn/go-isatty v0.0.16/go.mod h1:kYGgaQfpe5nmfYZH+SKPsOc2e4SrIfOl2e/yFXSvRLM=
 github.com/mattn/go-isatty v0.0.17 h1:BTarxUcIeDqL27Mc+vyvdWYSL28zpIhv3RoTdsLMPng=
 github.com/mattn/go-isatty v0.0.17/go.mod h1:kYGgaQfpe5nmfYZH+SKPsOc2e4SrIfOl2e/yFXSvRLM=
@@ -37,28 +34,25 @@ github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/
 github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO+kdMU+MU=
 github.com/stretchr/testify v1.8.1 h1:w7B6lhMri9wdJUVmEZPGGhZzrYTPvgJArz7wNPgYKsk=
 github.com/stretchr/testify v1.8.1/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o6fzry7u4=
-github.com/urfave/cli/v2 v2.23.7 h1:YHDQ46s3VghFHFf1DdF+Sh7H4RqhcM+t0TmZRJx4oJY=
-github.com/urfave/cli/v2 v2.23.7/go.mod h1:GHupkWPMM0M/sj1a2b4wUrWBPzazNrIjouW6fmdJLxc=
+github.com/urfave/cli/v2 v2.24.4 h1:0gyJJEBYtCV87zI/x2nZCPyDxD51K6xM8SkwjHFCNEU=
+github.com/urfave/cli/v2 v2.24.4/go.mod h1:GHupkWPMM0M/sj1a2b4wUrWBPzazNrIjouW6fmdJLxc=
 github.com/xrash/smetrics v0.0.0-20201216005158-039620a65673 h1:bAn7/zixMGCfxrRTfdpNzjtPYqr8smhKouy9mxVdGPU=
 github.com/xrash/smetrics v0.0.0-20201216005158-039620a65673/go.mod h1:N3UwUGtsrSj3ccvlPHLoLsHnpR27oXr4ZE984MbSER8=
 golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
 golang.org/x/crypto v0.0.0-20200323165209-0ec3e9974c59/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
 golang.org/x/crypto v0.0.0-20201208171446-5f87f3452ae9/go.mod h1:jdWPYTVW3xRLrWPugEBEK3UY2ZEsg3UU495nc5E+M+I=
-golang.org/x/crypto v0.4.0 h1:UVQgzMY87xqpKNgb+kDsll2Igd33HszWHFLmpaRMq/8=
-golang.org/x/crypto v0.4.0/go.mod h1:3quD/ATkf6oY+rnes5c3ExXTbLc8mueNue5/DoinL80=
+golang.org/x/crypto v0.6.0 h1:qfktjS5LUO+fFKeJXZ+ikTRijMmljikvG68fpMMruSc=
+golang.org/x/crypto v0.6.0/go.mod h1:OFC/31mSvZgRz0V1QTNCzfAI1aIRzbiufJtkMIlEp58=
 golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
 golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
 golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20191026070338-33540a1f6037/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
-golang.org/x/sys v0.0.0-20200116001909-b77594299b42/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20200219091948-cb0a6d8edb6c/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
-golang.org/x/sys v0.0.0-20200223170610-d5e6a3e2c0ae/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
-golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.3.0 h1:w8ZOecv6NaNa/zC8944JTU3vz4u6Lagfk4RPQxv92NQ=
-golang.org/x/sys v0.3.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/sys v0.5.0 h1:MUK/U/4lj1t1oPg0HfuXDN/Z1wv31ZJ/YcPiGccS4DU=
+golang.org/x/sys v0.5.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/term v0.0.0-20201117132131-f5c789dd3221/go.mod h1:Nr5EML6q2oocZ2LXRh80K7BxOlk5/8JxuGnuhpl+muw=
-golang.org/x/term v0.3.0 h1:qoo4akIqOcDME5bhc/NgxUdovd6BSS2uMsVjB56q1xI=
+golang.org/x/term v0.5.0 h1:n2a8QNdAb0sZNpU9R1ALUXBbY+w51fCQDN+7EdxNBsY=
 golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=

plugin.go

@@ -152,7 +152,7 @@ func (p Plugin) log(host string, message ...interface{}) {
 
 func (p *Plugin) removeDestFile(ssh *easyssh.MakeConfig) error {
 	p.log(ssh.Server, "remove file", p.DestFile)
-	_, errStr, _, err := ssh.Run(fmt.Sprintf("rm -rf %s", p.DestFile), p.Config.CommandTimeout)
+	_, errStr, _, err := ssh.Run(rmcmd(p.DestFile), p.Config.CommandTimeout)
 	if err != nil {
 		return err
 	}
@@ -322,20 +322,19 @@ func (p *Plugin) Exec() error {
 			}
 
 			for _, target := range p.Config.Target {
-				// remove target before upload data
+				// remove target folder before upload data
 				if p.Config.Remove {
 					p.log(host, "Remove target folder:", target)
 
-					_, _, _, err := ssh.Run(fmt.Sprintf("rm -rf %s", target), p.Config.CommandTimeout)
+					_, _, _, err := ssh.Run(rmcmd(target), p.Config.CommandTimeout)
 					if err != nil {
 						errChannel <- err
 						return
 					}
 				}
 
-				// mkdir path
 				p.log(host, "create folder", target)
-				_, errStr, _, err := ssh.Run(fmt.Sprintf("mkdir -p %s", target), p.Config.CommandTimeout)
+				_, errStr, _, err := ssh.Run(mkdircmd(target), p.Config.CommandTimeout)
 				if err != nil {
 					errChannel <- err
 					return